fix: Autocomplete focus scroll #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Apr 29, 2024
| @@ -281,6 +337,7 @@ export const SelectMultiple = (props: SelectMultipleProps) => { | |||
| aria-live="polite" | |||
| disableClearable | |||
| disableCloseOnSelect | |||
| disableListWrap | |||
There was a problem hiding this comment.
This was also flagged by @ianjon3s as a usability issue - you can now no longer wrap around from final → first option when navigating by keyboard.
DafyddLlyr
commented
Apr 29, 2024
Comment on lines
+183
to
+185
| // Using a custom listbox has a breaking effect on the native scroll used by MUI's Autocomplete | ||
| // Using a MutationObserver we can listen for MUI applying the focusVisible class | ||
| // We then use this to indicate that we need to scroll the focused element into view |
There was a problem hiding this comment.
This feels like a pretty complex solution to a small UI problem. Tried a few alternatives first, but if there's anything obvious I'm missing here please let me know!
ianjon3s
approved these changes
Apr 30, 2024
DafyddLlyr
force-pushed
the
dp/autocomplete-scroll-fix
branch
from
8ca955e to
478b9f2
Compare
|
Merged to #2993 as this will have another pair of eyes on it before going to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AutocompletecomponentDemo
Screen.Recording.2024-04-29.at.11.47.59.mov